Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conan] Copy dll files into correct build folders on Windows #502

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

IAmNotHanni
Copy link
Member

@IAmNotHanni IAmNotHanni commented Oct 8, 2022

Closes #499
I also removed the unused instructions for mac os which is not supported

  • Verify this does not break release workflow

@IAmNotHanni IAmNotHanni added cat:dev tools building/ compiling the program, cmake configuration and general development tools prio:high This has high priority. labels Oct 8, 2022
@IAmNotHanni IAmNotHanni self-assigned this Oct 8, 2022
Copy link
Member

@yeetari yeetari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really test, so assuming it works 😄

@IAmNotHanni
Copy link
Member Author

It does work, but we need to check if it affects devel release script :)

@IceflowRE
Copy link
Member

IceflowRE commented Oct 10, 2022

RUNTIME_OUTPUT_DIRECTORY
might be a look worth? Would have no hardcoded path.
So conan copies to bin/ and we copy then in CMake to the correct one?

Just saw CMAKE_MSVCIDE_RUN_PATH, might be the thing we need.

@IAmNotHanni
Copy link
Member Author

I don't think we can read CMake variables in conanfile.py? If not, we should just merge this fix as soon as possible because it affects debugging on Windows.

@IceflowRE
Copy link
Member

Ok i digged a bit deeper into this.

The better solution would be to copy those files in our cmake setup after the conan setup, to the correct directories, and only if we have a multi config setup.
I really want to avoid to copying all the .dll files multiples times if it is not required.

@IAmNotHanni
Copy link
Member Author

Can you set that up pls?

@IceflowRE IceflowRE self-assigned this Oct 26, 2022
Copy link
Member

@IceflowRE IceflowRE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as a temporary solution, will be finally fixed by #512

@IAmNotHanni IAmNotHanni merged commit 48d87e2 into main Nov 28, 2022
@IAmNotHanni IAmNotHanni deleted the hanni/fix_conan_win_config branch November 28, 2022 18:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:dev tools building/ compiling the program, cmake configuration and general development tools prio:high This has high priority.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: vulkan-1.dll from conan is in the wrong folder
3 participants