-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[conan] Copy dll files into correct build folders on Windows #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't really test, so assuming it works 😄
It does work, but we need to check if it affects devel release script :) |
Just saw CMAKE_MSVCIDE_RUN_PATH, might be the thing we need. |
I don't think we can read CMake variables in conanfile.py? If not, we should just merge this fix as soon as possible because it affects debugging on Windows. |
Ok i digged a bit deeper into this. The better solution would be to copy those files in our cmake setup after the conan setup, to the correct directories, and only if we have a multi config setup. |
Can you set that up pls? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as a temporary solution, will be finally fixed by #512
Closes #499
I also removed the unused instructions for mac os which is not supported