Add PHP-Parser 5 support #1084
maks-rafalkomt-annotations.yaml
on: pull_request
Matrix: tests
Annotations Status
0s
Annotations
3 warnings
|
Mutation Testing Code Review Annotations 8.1
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Mutation Testing Code Review Annotations 8.1:
src/Mutation/Mutation.php#L165
Escaped Mutant for Mutator "AssignCoalesce":
--- Original
+++ New
@@ @@
public function getNominalTestExecutionTime(): float
{
// TestLocator returns non-unique tests, and JUnitTestCaseSorter works around that; we have to do that too.
- return $this->nominalTimeToTest ??= (new JUnitTestCaseTimeAdder($this->tests))->getTotalTestTime();
+ return $this->nominalTimeToTest = (new JUnitTestCaseTimeAdder($this->tests))->getTotalTestTime();
}
public function getHash(): string
{
|
|
Mutation Testing Code Review Annotations 8.1:
src/Mutation/Mutation.php#L170
Escaped Mutant for Mutator "AssignCoalesce":
--- Original
+++ New
@@ @@
}
public function getHash(): string
{
- return $this->hash ??= $this->createHash();
+ return $this->hash = $this->createHash();
}
private function createHash(): string
{
|