Use php-cs-fixer from Makefile in order to keep same version #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… local and ci checks
maks-rafalko
approved these changes
Feb 22, 2021
…t dir of the project
sidz
commented
Feb 22, 2021
| @@ -19,7 +19,7 @@ BOX_URL="https://github.com/humbug/box/releases/download/3.10.0/box.phar" | |||
|
|
|||
| PHP_CS_FIXER=./.tools/php-cs-fixer | |||
| PHP_CS_FIXER_URL="https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.18.2/php-cs-fixer.phar" | |||
| PHP_CS_FIXER_CACHE=build/cache/.php_cs.cache | |||
| PHP_CS_FIXER_CACHE=.php_cs.cache | |||
There was a problem hiding this comment.
php-cs-fixer doesn't create folder if folder doesn't exist. And I wouldn't create an additional step just for this case.
Hope this is not an issue
sidz
commented
Feb 22, 2021
Comment on lines
+72
to
+73
| LC_ALL=C sort -c -u .gitignore | ||
| $(MAKE) check_trailing_whitespaces |
There was a problem hiding this comment.
an additional plus that CI will run these checks as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI uses ab old version of PHP-CS-Fixer - 2.17.3 but Makefile downloads - 2.18.2.
This PR fixes this and now GA going to run
cs-checkfrom Makefile.Initial discussion was in the #1487 (review).