tests(makefile): moved cs-fixer download to GitHub releases #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
maks-rafalko
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Well, this is a little bit different behaviour, as previously we downloaded the latest version, but now it's sticked to exact one.
However, for me it's better, because when the new PHP-CS-Fixer version is released, we always have failed builds without any code changes, which is not good.
I'm 👍 here
sanmai
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
When executing make cs cs-fixer was not properly downloaded.
https://cs.sensiolabs.org/download/php-cs-fixer-v2.phar seems to be offline.
I decided to move over to GitHub releases of cs-fixer.
Let me know if this is the way you want this to be fixed,