New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micro optimization to reduce array_merge calls #1883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
sanmai
approved these changes
Oct 15, 2023
…one path string is added in excludes source config
sidz
force-pushed
the
call-notpath-once
branch
from
October 16, 2023 17:05
25fc2f6
to
81ca1c8
Compare
maks-rafalko
approved these changes
Oct 16, 2023
Bot blocks auto-merge, merging by hand. Thanks @sidz |
github-merge-queue bot
pushed a commit
to Lendable/clock
that referenced
this pull request
Nov 2, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [infection/infection](https://togithub.com/infection/infection) | `^0.27.6` -> `^0.27.7` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/infection%2finfection/0.27.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/infection%2finfection/0.27.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/infection%2finfection/0.27.6/0.27.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/infection%2finfection/0.27.6/0.27.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>infection/infection (infection/infection)</summary> ### [`v0.27.7`](https://togithub.com/infection/infection/releases/tag/0.27.7): PHP 8.3, Symfony 7 support [Compare Source](https://togithub.com/infection/infection/compare/0.27.6...0.27.7) **Changed:** - Add Symfony 7 support by [@​sidz](https://togithub.com/sidz) in [infection/infection#1892 - Allow `fidry/cpu-core-counter` v1 by [@​Slamdunk](https://togithub.com/Slamdunk) in [infection/infection#1893 - Micro optimization to reduce array_merge calls by [@​sidz](https://togithub.com/sidz) in [infection/infection#1883 - Remove `symfony/console` < 4.4 hack as minimum supported version is 5.4 by [@​sidz](https://togithub.com/sidz) in [infection/infection#1888 - Remove all deprecated Safe function usages by [@​sidz](https://togithub.com/sidz) in [infection/infection#1889 - Update sanmai/pipeline to the latest version by [@​sanmai](https://togithub.com/sanmai) in [infection/infection#1890 **Full Changelog**: infection/infection@0.27.6...0.27.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/clock). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a big win but this is a micro optimization will reduce amount of
array_merge
calls in caseexcludes
option has more than one entry as Finder is doing array merge all the timenotPath
is called.see https://github.com/symfony/finder/blob/5.4/Finder.php#L288