Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for sebastian/diff v6 #1913

Merged
merged 2 commits into from Feb 20, 2024
Merged

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Feb 4, 2024

This PR:

Adds support for sebastian/diff v6

@simPod
Copy link
Contributor Author

simPod commented Feb 4, 2024

Test failure is irrelevant. For some reason it install php-parser v5.

@sidz sidz mentioned this pull request Feb 9, 2024
1 task
@maks-rafalko
Copy link
Member

maks-rafalko commented Feb 11, 2024

For some reason it install php-parser v5.

it installs it because we don't specify any version of php-parser in e2e tests and we don't use Infection's composer.json there - we just depend on phpunit and it installs all the dependencies:

composer why nikic/php-parser 

phpunit/php-code-coverage 9.2.30 requires nikic/php-parser (^4.18 || ^5.0) 
sebastian/complexity      2.0.3  requires nikic/php-parser (^4.18 || ^5.0) 
sebastian/lines-of-code   1.0.4  requires nikic/php-parser (^4.18 || ^5.0)

since we have here ^4.18 || ^5.0 - by default composer for e2e test installs nikic/php-parser:^5.0.

It worked before, because API was the same among any of the 4.* version, and we were lucky that there weren't any issues like that before.

Now, this is a problem.

I don't really know what is the best way to handle it at the moment, but will try to think outloud

@sidz do you have other ideas?

The issue is relevant when we use bin/infection, not build/infection.phar since it's prefixed and shouldn't conflict with vendor's code.

@sidz
Copy link
Member

sidz commented Feb 12, 2024

The second option is looking fine from me @maks-rafalko.

@maks-rafalko maks-rafalko merged commit 873cd33 into infection:master Feb 20, 2024
55 checks passed
@maks-rafalko
Copy link
Member

Thank you @simPod

@maks-rafalko
Copy link
Member

github-merge-queue bot pushed a commit to Lendable/clock that referenced this pull request Feb 20, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [infection/infection](https://togithub.com/infection/infection) |
`^0.27.9` -> `^0.27.10` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/infection%2finfection/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/infection%2finfection/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/infection%2finfection/0.27.9/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/infection%2finfection/0.27.9/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>infection/infection (infection/infection)</summary>

###
[`v0.27.10`](https://togithub.com/infection/infection/releases/tag/0.27.10):
Add support for &#x60;sebastian/diff&#x60; v6

[Compare
Source](https://togithub.com/infection/infection/compare/0.27.9...0.27.10)

**Changed:**

- feat: add support for `sebastian/diff` v6 by
[@&#8203;simPod](https://togithub.com/simPod) in
[infection/infection#1913
- Use `is_numeric` do detect numeric strings in
ArgumentsAndOptionsBuilder by
[@&#8203;sanmai](https://togithub.com/sanmai) in
[infection/infection#1904
- Enable Box Requirements Checker by
[@&#8203;sidz](https://togithub.com/sidz) in
[infection/infection#1906

**Full Changelog**:
infection/infection@0.27.9...0.27.10

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Lendable/clock).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@simPod
Copy link
Contributor Author

simPod commented Feb 20, 2024

Thank you for finishing this.

@simPod simPod deleted the diff branch February 20, 2024 07:53
github-merge-queue bot pushed a commit to Lendable/json-serializer that referenced this pull request Feb 29, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [infection/infection](https://togithub.com/infection/infection) |
`^0.27.9` -> `^0.27.10` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/infection%2finfection/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/infection%2finfection/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/infection%2finfection/0.27.9/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/infection%2finfection/0.27.9/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [php-cs-fixer/shim](https://togithub.com/PHP-CS-Fixer/shim) |
`^3.49.0` -> `^3.51.0` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/php-cs-fixer%2fshim/3.51.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/php-cs-fixer%2fshim/3.51.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/php-cs-fixer%2fshim/3.49.0/3.51.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/php-cs-fixer%2fshim/3.49.0/3.51.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [phpstan/phpstan](https://togithub.com/phpstan/phpstan) | `^1.10.58`
-> `^1.10.59` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/phpstan%2fphpstan/1.10.59?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/phpstan%2fphpstan/1.10.59?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/phpstan%2fphpstan/1.10.58/1.10.59?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/phpstan%2fphpstan/1.10.58/1.10.59?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[phpstan/phpstan-phpunit](https://togithub.com/phpstan/phpstan-phpunit)
| `^1.3.15` -> `^1.3.16` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/phpstan%2fphpstan-phpunit/1.3.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/phpstan%2fphpstan-phpunit/1.3.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/phpstan%2fphpstan-phpunit/1.3.15/1.3.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/phpstan%2fphpstan-phpunit/1.3.15/1.3.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [phpunit/phpunit](https://phpunit.de/)
([source](https://togithub.com/sebastianbergmann/phpunit)) | `^10.5.10`
-> `^10.5.11` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/phpunit%2fphpunit/10.5.11?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/phpunit%2fphpunit/10.5.11?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/phpunit%2fphpunit/10.5.10/10.5.11?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/phpunit%2fphpunit/10.5.10/10.5.11?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>infection/infection (infection/infection)</summary>

###
[`v0.27.10`](https://togithub.com/infection/infection/releases/tag/0.27.10):
Add support for &#x60;sebastian/diff&#x60; v6

[Compare
Source](https://togithub.com/infection/infection/compare/0.27.9...0.27.10)

**Changed:**

- feat: add support for `sebastian/diff` v6 by
[@&#8203;simPod](https://togithub.com/simPod) in
[infection/infection#1913
- Use `is_numeric` do detect numeric strings in
ArgumentsAndOptionsBuilder by
[@&#8203;sanmai](https://togithub.com/sanmai) in
[infection/infection#1904
- Enable Box Requirements Checker by
[@&#8203;sidz](https://togithub.com/sidz) in
[infection/infection#1906

**Full Changelog**:
infection/infection@0.27.9...0.27.10

</details>

<details>
<summary>PHP-CS-Fixer/shim (php-cs-fixer/shim)</summary>

###
[`v3.51.0`](https://togithub.com/PHP-CS-Fixer/shim/compare/v3.50.0...v3.51.0)

[Compare
Source](https://togithub.com/PHP-CS-Fixer/shim/compare/v3.50.0...v3.51.0)

###
[`v3.50.0`](https://togithub.com/PHP-CS-Fixer/shim/compare/v3.49.0...v3.50.0)

[Compare
Source](https://togithub.com/PHP-CS-Fixer/shim/compare/v3.49.0...v3.50.0)

</details>

<details>
<summary>phpstan/phpstan (phpstan/phpstan)</summary>

###
[`v1.10.59`](https://togithub.com/phpstan/phpstan/releases/tag/1.10.59)

[Compare
Source](https://togithub.com/phpstan/phpstan/compare/1.10.58...1.10.59)

# Bleeding edge 🔪

- `array_values` rule (report when a `list` type is always passed in)
([#&#8203;2917](https://togithub.com/phpstan/phpstan-src/pull/2917)),
thanks [@&#8203;kamil-zacek](https://togithub.com/kamil-zacek)!

*If you want to see the shape of things to come and adopt bleeding edge
features early, you can include this config file in your project's
`phpstan.neon`:*

    includes:
    	- vendor/phpstan/phpstan/conf/bleedingEdge.neon

*Of course, there are no backwards compatibility guarantees when you
include this file. The behaviour and reported errors can change in minor
versions with this file included. [Learn
more](https://phpstan.org/blog/what-is-bleeding-edge)*

# Improvements 🔧

- ArrayFilterRule - tip message about `treatPhpDocTypesAsCertain`
(phpstan/phpstan-src@f5b198c)
- ArgumentsNormalizer - skip unused arguments in non-variadic
signatures, still return a normalized call
(phpstan/phpstan-src@17e5bac)
- Methods in fluent interfaces are considered impure
(phpstan/phpstan-src@b026126)
- Add type-specifying extension for `settype()`
([#&#8203;2920](https://togithub.com/phpstan/phpstan-src/pull/2920)),
thanks [@&#8203;ChrisBrenton](https://togithub.com/ChrisBrenton)!

# Bugfixes 🐛

- MethodAssertRule - do not report implicitly inherited assert tags
(phpstan/phpstan-src@299df51),
[#&#8203;10573](https://togithub.com/phpstan/phpstan/issues/10573)
- Gets rid of the annoying error "Asserted type ... with type ... does
not narrow down the type."
- ConstantArrayType - string offset might exist as integer offset
(phpstan/phpstan-src@2fb6632),
[#&#8203;10577](https://togithub.com/phpstan/phpstan/issues/10577)

# Internals 🔍

- Parallelize levels tests
([#&#8203;2916](https://togithub.com/phpstan/phpstan-src/pull/2916)),
thanks [@&#8203;staabm](https://togithub.com/staabm)!
- `FunctionReflection::isPure()` and
`ExtendedMethodReflection::isPure()`
(phpstan/phpstan-src@03d01ea)

</details>

<details>
<summary>phpstan/phpstan-phpunit (phpstan/phpstan-phpunit)</summary>

###
[`v1.3.16`](https://togithub.com/phpstan/phpstan-phpunit/releases/tag/1.3.16)

[Compare
Source](https://togithub.com/phpstan/phpstan-phpunit/compare/1.3.15...1.3.16)

-
[d5242a5](http://github.com/phpstan/phpstan-phpunit/commit/d5242a59d035e46774f2e634b374bc39ff62cb95)
- Narrow type on assertCount and assertNotCount

</details>

<details>
<summary>sebastianbergmann/phpunit (phpunit/phpunit)</summary>

###
[`v10.5.11`](https://togithub.com/sebastianbergmann/phpunit/compare/10.5.10...10.5.11)

[Compare
Source](https://togithub.com/sebastianbergmann/phpunit/compare/10.5.10...10.5.11)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Lendable/json-serializer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants