Additional PHPUnit 10 compatibility fixes #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e have tests in matrix
…an internal or external command,`
…dge env var from `phpunit.xml`
maks-rafalko
approved these changes
Mar 19, 2024
theofidry
reviewed
Mar 19, 2024
| use PHPUnit\Framework\Constraint\Callback; | ||
| use PHPUnit\Framework\Constraint\Constraint; | ||
|
|
||
| trait PHPUnitConvecutiveReplacement |
There was a problem hiding this comment.
- typo:
PHPUnitConvecutiveReplacement->PHPUnitConsecutiveReplacement? - why does hthis need to be a trait if the only thing it contains is a static method? This could very well be a class with a private constructor (there is
self::assert*but that could be fixed by using PHPUnit Assertion directly) - might warrant some docs? This is a very confusing piece of code IMO
Also might warrant some docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
I'm looking to reduce the diff from #1921 to the bare minimum so we can investigate it further.