Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phar distribution #2

Merged
merged 3 commits into from Jul 8, 2017
Merged

Phar distribution #2

merged 3 commits into from Jul 8, 2017

Conversation

maks-rafalko
Copy link
Member

The first implementation of Phar distribution and self-update command

Signed-off-by: borNfreee <b0rn@list.ru>
Signed-off-by: borNfreee <b0rn@list.ru>
Signed-off-by: borNfreee <b0rn@list.ru>
@codecov-io
Copy link

codecov-io commented Jul 8, 2017

Codecov Report

Merging #2 into master will decrease coverage by 2.35%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #2      +/-   ##
============================================
- Coverage     36.16%   33.81%   -2.36%     
- Complexity      638      666      +28     
============================================
  Files           112      113       +1     
  Lines          1941     2076     +135     
============================================
  Hits            702      702              
- Misses         1239     1374     +135
Impacted Files Coverage Δ Complexity Δ
src/Command/SelfUpdateCommand.php 0% <0%> (ø) 28 <28> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7315163...e8c5889. Read the comment docs.

@maks-rafalko maks-rafalko merged commit 21b75ed into master Jul 8, 2017
@maks-rafalko maks-rafalko deleted the phar-distribution branch August 20, 2017 18:58
@3DFace 3DFace mentioned this pull request Aug 29, 2017
sanmai referenced this pull request in sanmai/infection May 10, 2018
Parameter #2 $env of method Symfony\Component\Process\Process::start() expects array, array|null given.
maks-rafalko pushed a commit that referenced this pull request May 10, 2018
…t process (#329)

* Got back PhpExecutableFinderTest

* Use a default Xdebug-free environment for all subprocesses

* Extended test suite for Exec_Path e2e test

* Added docblock comments

* Use setTimeout() instead of a long list of null'ed constructor's options

* setupEnvironment() renamed into setupXdebugFreeEnvironment()

* A comment about restoring environment

* ProjectCodeTest should only consider our own classes

We should consider only properties belonging to our classes, but not to foreign classes
we're exteding from. E.g. we can't change Symfony\Component\Process\Process to not have
a public propery it has.

* PhpExecutableFinderTest tagges as internal/final

* Fix for Process::start() API incompatibility with version 4

Parameter #2 $env of method Symfony\Component\Process\Process::start() expects array, array|null given.
maks-rafalko added a commit that referenced this pull request Dec 9, 2020
* create mutators

* avaible only string param

* unit tests

* cs-fix

* mutatesNode rule

* coallesce on mutators

* regex only removes carret and dolar

* code format

* riddiculus pretty fix

* Add mutators to schema.json, add more tests, add psalm annotations, add support for all possible delimiters

* Add psalm issues to baseline because thecodingmachine/safe does not support psalm annotations yet

thecodingmachine/safe#141

* Add test with an unpacked array

* Simplify code by using ?? operator

Co-authored-by: bernard.van.der.esch <bernard.van.der.esch@orba.co>
Co-authored-by: Bernard van der Esch <b.vanderesch@gmail.com>
maks-rafalko added a commit that referenced this pull request Aug 7, 2021
…andom ordering of the tests since we need them to be sorted (fastest - first)

When Infection build Mutant's `phpunit.xml` file, we add `<file>` tags, sorted by tests execution time, so that the fastest tests runs first.

But when the original `phpunit.xml` contains `executionOrder="default"`, it was inherited to Mutant's `phpunit.xml` and broke the order, running the tests in a random order each time `infection` was executed.

This also explains why I got different execution time of Infection for the project with *functional* tests.

When Mutant is covered by 1000 functional tests, and tests are executed by random, it can be killed by the first test in run #1 and can be killed by 1000-th test in run #2, if the killing test is executed the last.

With this update, all the tests will be executed in the same orders (fastest - first) in all the infection runs.
maks-rafalko added a commit that referenced this pull request Aug 7, 2021
…andom ordering of the tests since we need them to be sorted (fastest - first) (#1547)

When Infection build Mutant's `phpunit.xml` file, we add `<file>` tags, sorted by tests execution time, so that the fastest tests runs first.

But when the original `phpunit.xml` contains `executionOrder="default"`, it was inherited to Mutant's `phpunit.xml` and broke the order, running the tests in a random order each time `infection` was executed.

This also explains why I got different execution time of Infection for the project with *functional* tests.

When Mutant is covered by 1000 functional tests, and tests are executed by random, it can be killed by the first test in run #1 and can be killed by 1000-th test in run #2, if the killing test is executed the last.

With this update, all the tests will be executed in the same orders (fastest - first) in all the infection runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants