Fix performance bottleneck by introducing a simple instance-level object cache #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a performance issue with opening and parsings (XPath)
junit.xml
thousands of times instead of caching the results.This update eliminates the issue.
Blackfire comparison before/after: https://blackfire.io/profiles/compare/a6ef3b53-93c5-44b4-bf16-9c2510b44e61/graph?settings%5Bdimension%5D=wt&settings%5Bdisplay%5D=landscape&settings%5BtabPane%5D=nodes&selected=&callname=main()
On infection itself, the number of
DomDocument::loadXML
calls reduced by almost 8k times.