Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inferno 4.5.1 and 4.5.2 TypeScript typing errors #1377

Closed
naruaway opened this issue Aug 26, 2018 · 3 comments
Closed

Inferno 4.5.1 and 4.5.2 TypeScript typing errors #1377

naruaway opened this issue Aug 26, 2018 · 3 comments
Labels

Comments

@naruaway
Copy link
Contributor

Hello! Thank you for creating this awesome library.

I encountered a lot of typing errors when updating to Inferno 4.5.2 from 4.5.0.

I found that when using Inferno 4.5.1 and 4.5.2 with TypeScript,
tsc emits a lot of typing errors.
For you to check them, I created a repo for reproducing these errors.

With Inferno 4.5.0, there were no errors and it successfully compiled with tsc.

So I suspect this commit is related to the problem.

@Havunen
Copy link
Member

Havunen commented Aug 26, 2018

without using outputAsModuleFolder -option, dts-bundle emits declare module and namespace stuff which is not valid for external libraries... Do you have any glue how to fix this?

@Havunen
Copy link
Member

Havunen commented Sep 1, 2018

I found way to fix this. We need to include all typescript definitions created by typescript compiler with the library. I will make that change and release 5.5.0, That should work in both use cases. I also removed dts-bundle it seems not to be maintained.

@Havunen
Copy link
Member

Havunen commented Sep 1, 2018

Inferno v5.5.0 released, it should fix this.

@Havunen Havunen closed this as completed Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants