Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow suppress warnings for polyfilled components using legacy life c… #1461

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

alanlima
Copy link
Contributor

Objective

This PR does not show warnings when using mix legacy life cycle API's (old and new) and they are suppressed by polyfilled components.

Closes Issue

It closes Issue #1458.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage increased (+0.03%) to 95.064% when pulling 2a0c345 on alanlima:suppress-warnings into ddd874d on infernojs:master.

@Havunen
Copy link
Member

Havunen commented Mar 21, 2019

Hi @alanlima
Thank you for your PR! LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants