-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cross-browser innerhtml fixes #546
Conversation
CCing @Havunen @nightwolfz @LukeSheard for review |
Thanks @Abazhenov this is great stuff! :) Have you tested that all tests pass on |
Meh, the Travis build failed due to an NVM issue.. |
I think you forgot to commit the tools file / import it from some of the tests. But otherwise this looks great! |
All tests are passing on my end |
@LukeSheard OK I'll look it over, innerHTML was already defined in src/tools/utils on line 11, also, some files already had it imported prior to my changes. |
@LukeSheard hopefully this is more clear, innerHTML should be required in all the files that need it |
Okay. I'm only on some app my iPhone so this isn't a proper review. Thanks! |
I'm quite happy to merge this, but we should add a chore issue to tidy up all instances of testing HTML strings with |
Fixes some tests that were failing when running browsers other than google chrome.
Some tests were failing because where chrome would render:
<input class="foo" id="test">
Firefox / safari / edge might render:
<input id="test" class="foo">
This PR uses our innerHTML utility to fix those tests and ensure that the strings we are comparing rendered components to correspond to what they would be in the browser running the tests.
This only addresses compatibility issues that have to do with comparing HTML strings.