Hrcpp 390/rm some expected fail #302
Conversation
There was a problem hiding this comment.
Just some formatting issues in the PR comments, but I am seeing these tests fail:
The following tests FAILED:
16 - simpleSasl (OTHER_FAULT)
22 - simple-tls (OTHER_FAULT)
23 - simple-tls-sni (Failed)
28 - simple-tls-client-auth (OTHER_FAULT)
29 - simple-tls-sni-client-auth (Failed)
| this.marshaller = marshaller2; | ||
| this.servers = null; | ||
| this.failoverServers = null; | ||
| this.transportFactory = null; |
There was a problem hiding this comment.
Indentation looks wrong on this line
| @@ -290,8 +289,9 @@ public Configuration create() { | |||
|
|
|||
| @Override | |||
| public Configuration build() { | |||
| return new Configuration(this.jniConfigurationBuilder.build()); | |||
| } | |||
| return (marshaller != null) ? new Configuration(this.jniConfigurationBuilder.build(), marshaller) | |||
There was a problem hiding this comment.
Indentation looks wrong on these lines
| @@ -78,19 +78,35 @@ public RemoteCacheManager(Properties props, boolean start) { | |||
| } | |||
|
|
|||
| public <K, V> org.infinispan.client.hotrod.RemoteCache<K, V> getCache() { | |||
| return new org.infinispan.client.hotrod.impl.RemoteCacheImpl<K, V>(this, "", false); | |||
| try { | |||
| return new org.infinispan.client.hotrod.impl.RemoteCacheImpl<K, V>(this, "", false); | |||
There was a problem hiding this comment.
Indentation look wrong in all four of these methods
rigazilla
force-pushed
the
HRCPP-390/rm_some_expected_fail
branch
from
2288b1f
to
4e44015
Compare
|
I've removed the tabs. It seems that you had an infinispan server already running before you run the test suite. This conflicts with the TLS and SASL startup. |
|
adding @mgencur as reviewer since he's the reporter of this issue. |
|
@rigazilla ok, code and tests look good to me now. 👍 |
|
@alanfx if it's all ok can you merge? thanx! |
There was a problem hiding this comment.
@rigazilla just some minor nits and a question. The tests are passing on my machine, though.
| @@ -17,19 +17,19 @@ | |||
| import org.testng.reporters.TextReporter; | |||
| @@ -158,18 +155,17 @@ when main() returns. */ | |||
|
|
|||
| @Override | |||
| public boolean includeMethod(IMethodSelectorContext context, ITestNGMethod method, boolean isTestMethod) { | |||
There was a problem hiding this comment.
It looks like the indentation for includeMethod and setTestMethods is off?
| @@ -178,9 +178,8 @@ public ConfigurationBuilder marshaller(Class<? extends Marshaller> marshaller) { | |||
|
|
|||
There was a problem hiding this comment.
Should this^^^ version of the method work too?
rigazilla
force-pushed
the
HRCPP-390/rm_some_expected_fail
branch
from
4e44015
to
50b17b5
Compare
|
Looks good to me. Merging... |
This PR contains changes on the swig wrapper that remove some of expected failure in the java test list.
Plus a fix on the client that now correctly set the force return value flag in the request.
https://issues.jboss.org/browse/HRCPP-390