-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hrcpp 390/rm some expected fail #302
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -178,9 +178,8 @@ public ConfigurationBuilder marshaller(Class<? extends Marshaller> marshaller) { | |
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this^^^ version of the method work too? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok enabled |
||
@Override | ||
public ConfigurationBuilder marshaller(Marshaller marshaller) { | ||
throw new UnsupportedOperationException(); | ||
// this.marshaller = marshaller; | ||
// return this; | ||
this.marshaller = marshaller; | ||
return this; | ||
} | ||
|
||
@Override | ||
|
@@ -290,8 +289,9 @@ public Configuration create() { | |
|
||
@Override | ||
public Configuration build() { | ||
return new Configuration(this.jniConfigurationBuilder.build()); | ||
} | ||
return (marshaller != null) ? new Configuration(this.jniConfigurationBuilder.build(), marshaller) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indentation looks wrong on these lines |
||
: new Configuration(this.jniConfigurationBuilder.build(), marshaller); | ||
} | ||
|
||
public Configuration build(boolean validate) { | ||
if (validate) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation looks wrong on this line