HRCPP-137 C# hotrod client - reuse tests from the java client #27
Conversation
|
I don't understand why you're including the hotrod client sources in the PR and not pulling them in via maven ? |
|
It's the same approach as in the jni tests for the C++ client. Some of the classes are modified to call into the C# code (e.g. RemoteCacheImpl) but some indeed are just copied. Not sure why this approach is used in the C++ client and if there are some pitfalls in reusing the client from maven. It's for sure cleaner than duplicating code. I'll give it a try with the jar reused from maven and the classes which are modified before that jar on the classpath. |
|
Running C# tests fails on my machine due to uninitialized variables, when an exception is thrown in some methods. Here is a fix: |
|
@rvansa would you mind sending a PR for the fix? I've added an issue for it https://issues.jboss.org/browse/HRCPP-143 and assigned it to you. Thank you for tracking this down! |
|
Reusing the java classes from maven will be handled in HRCPP-144. |
|
@isavin OK, the fix depends on this PR to be integrated, therefore, I can't file it as PR... You can grab it into this PR, if you want... |
|
It's in ! Thanks guys. |
https://issues.jboss.org/browse/HRCPP-137