Hrcpp 262/pull csharp ssl #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ConfigurationBuilder conf = new ConfigurationBuilder(); | ||
| conf.AddServer().Host("127.0.0.1").Port(11222).ConnectionTimeout(90000).SocketTimeout(900); | ||
| SslConfigurationBuilder sslConfB = conf.Ssl(); | ||
| sslConfB.Enable().ServerCAFile("c:\\tmp\\infinispan-ca.pem"); |
There was a problem hiding this comment.
Please commit the pem file as part of the test
rigazilla
force-pushed
the
HRCPP-262/pull_csharp_ssl
branch
2 times, most recently
from
270a16b
to
159b991
Compare
|
added and rebased |
| ConfigurationBuilder conf = new ConfigurationBuilder(); | ||
| conf.AddServer().Host("127.0.0.1").Port(11222).ConnectionTimeout(90000).SocketTimeout(900); | ||
| SslConfigurationBuilder sslConfB = conf.Ssl(); | ||
| if (!System.IO.File.Exists("c:\\tmp\\infinispan-ca.pem")) |
There was a problem hiding this comment.
Can't you point to the proper file directly ?
|
probably I can arrange the build to copy the file in the same place of the executable and then use a relative path. |
rigazilla
force-pushed
the
HRCPP-262/pull_csharp_ssl
branch
from
159b991
to
5b76c89
Compare
|
ok done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ssl integration for C# hotrod client