ISPN-7342 - Cassandra Cache Store is missing Custom Cache Store service manifest #10
Conversation
| <description>Infinispan CassandraCacheStore module</description> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> |
There was a problem hiding this comment.
Could you please reformat it along with our Infinispan formatter?
There was a problem hiding this comment.
added dependency for testng to fix compilation issue
| </exclusions> | ||
| </dependency> | ||
| <properties> | ||
| <checkstyle.skip>true</checkstyle.skip> |
| <optional>true</optional> | ||
| </dependency> | ||
|
|
||
| <!-- https://mvnrepository.com/artifact/org.testng/testng --> |
| <version>6.10</version> | ||
| </dependency> | ||
|
|
||
| <!-- https://mvnrepository.com/artifact/org.mockito/mockito-all --> |
| <build> | ||
| <!-- testResources> | ||
| <testResource> | ||
| <directory>src/test/resources</directory> |
There was a problem hiding this comment.
Reverted changes, please review
| @@ -1 +0,0 @@ | |||
| org.infinispan.persistence.cassandra.configuration.CassandraStoreConfigurationParser82 | |||
There was a problem hiding this comment.
Reverted changes, please review
…ck these once the pull request is accpted
|
Please check now, I have reverted few changes made as per my project requirement. |
|
Please check now, I have reverted few changes made as per my project requirement. |
| @@ -1 +0,0 @@ | |||
| org.infinispan.persistence.cassandra.configuration.CassandraStoreConfigurationParser82 | |||
There was a problem hiding this comment.
Reverted changes, please review
| <build> | ||
| <!-- testResources> | ||
| <testResource> | ||
| <directory>src/test/resources</directory> |
There was a problem hiding this comment.
Reverted changes, please review
nmvijay
changed the title
nmvijay
changed the title
|
|
||
| <dependency> | ||
| <groupId>org.testng</groupId> | ||
| <artifactId>testng</artifactId> |
There was a problem hiding this comment.
And also, there is no need to change permissions of org.infinispan.configuration.parsing.ConfigurationParser file.
There was a problem hiding this comment.
Ha! Now I see it... TestNG is required...
https://issues.jboss.org/browse/ISPN-7342
Created proper /META-INF/services/org.infinispan.persistence.spi.AdvancedLoadWriteStore entry pointing to CassandraStore class.