Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-7310: Make Console Use Digest Authentication. #167

Closed
wants to merge 2 commits into from

Conversation

ryanemerson
Copy link
Collaborator

https://issues.jboss.org/browse/ISPN-7310

@vblagoje I haven't had a chance to check this with IE yet, however it does work with Chrome and Firefox on Fedora.

@vblagoje
Copy link

@ryanemerson reload does not work with digest addition :-(

@ryanemerson
Copy link
Collaborator Author

@vblagoje Can you elaborate on what you mean by "reload" please?. Page refresh, both manually and using the console buttons works for me. Also the browser remains authenticated during server stoppages and reloads after a config change.

@vblagoje
Copy link

@ryanemerson apologies. When I do cmd+R (reload on mac) for the containers page - it works. However, it does not work for any other page/view we have. I either get the blank white screen or the screen below
screen shot 2016-12-13 at 5 49 38 am

@vblagoje
Copy link

And this "reload issue" happens on Firefox, Chrome and Opera. Did not turn on my VirtualBox and IE yet :-)

@ryanemerson
Copy link
Collaborator Author

@vblagoje Argh I see, I'm getting similar behaviour on some screens. I'll look into it now

@vblagoje
Copy link

Good news @ryanemerson IE 11 seems to work really good. Even the errors where new caches, configuration templates did not show up upon adding them - seem to work. I found one error so far though. Upon loggin out I get this screen.
screen shot 2016-12-13 at 6 09 16 am

@ryanemerson
Copy link
Collaborator Author

ryanemerson commented Dec 13, 2016

@vblagoje Awesome :). I think the reason logout isn't working on IE is because of the way I force the app to reload by using windows.href.

I spoke to @tristantarrant earlier and we've decided to add a splash screen, as an entry point to the user, which will have the branding etc and a login button. Once the login button is clicked, the first request to the server will be initiated and the browser login prompt will appear and then when the user clicks logout they will be returned to the splash screen. So I will incorporate ^ changes into this PR and hopefully that will remove the need to use windows.href and those IE issues.

@vblagoje
Copy link

Awesome @ryanemerson , keep me in the loop. In the meantime, I will download and install more IE versions and make sure everything is ready to go for IE support!

@vblagoje
Copy link

@ryanemerson IE10 works as well. No problems noticed other than the logout issue already described

@ryanemerson
Copy link
Collaborator Author

@vblagoje The latest commit will hopefully have resolved the refresh issue. I will push another commit to this PR with the welcome splash screen

@vblagoje
Copy link

Integrated with 948b1bd Great work @ryanemerson

@vblagoje vblagoje closed this Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants