Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-5814 View cross site replication state #38

Closed
wants to merge 4 commits into from
Closed

ISPN-5814 View cross site replication state #38

wants to merge 4 commits into from

Conversation

pzapataf
Copy link
Contributor

Please, note this PR depends on merging ISPN-6063 first.

@vblagoje
Copy link

Nice @pzapataf Will take a look eod today! Cheers!

@@ -109,7 +109,33 @@ <h2 class="card-pf-title">

<div class="row row-cards-pf">
<!-- BEGIN CARD -->
<div class="col-xs-2 col-sm-2 col-md-2" match-height="ispn-card">
<div class="col-xs-6 col-sm-4 col-md-3" match-height="ispn-card"
ng-if="currentCacheStats.firstServerStats['offline-sites'].length > 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pzapataf make this one a method in controller. The logic in view should be kept to a minimum!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as sugested by @tristantarrant, I've changed the names of the attributes:
infinispan/infinispan#3948 (comment)

the current names are sites-online, sites-offline and sites-mixed

@tristantarrant
Copy link
Member

This has already been merged, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants