ISPN-5809 - View of cluster events #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $scope.refreshGridEvents = function() { | ||
| $scope.gridEvents = []; | ||
| angular.forEach($scope.clusters, function(cluster){ | ||
| $scope.refreshClusterEvents(cluster, 10); |
There was a problem hiding this comment.
@pzapataf make 10 a variable somewhere so we can extract/configure it elsewhere if needed
|
Great stuff @pzapataf If you want to experiement just a bit more make a events-service.js that will extract business logic of DMR into it and thus simplify your controller. Now we have a lot of DMR logic in controllers that we have to slowly move into services. You can do it now, if you have time and desire. If now, I'll do it soon enough across the entire codebse. |
|
This has already been merged, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.