Offer Docker image, fix Teiid typos

[emmanuelbernard]

No description provided.

[rvansa]

hibernate.org?

[emmanuelbernard]

I've fixed the incorrect reference and forced push.

[gustavocoding]

Those two RUN could be collapsed in a single line to minimize number of layers

[emmanuelbernard]

That's an interesting debate. I understand the demise of Docker caching but for that specific image maintained by non docker experts and used on the desktop (not in prod or anything), is it a good trade off to collapse these layers? I'm open to collapse but it has a bit of a readability cost.

[gustavocoding]

The second line just installs wget, so it actually does not help the readability

[emmanuelbernard]

I'll do it but the wget for example is not required by the hibernate version of this.

[gustavocoding]

@emmanuelbernard looks good!
Question: would that strategy work with a pre-build docker image (ideally as an automated build on https://hub.docker.com/) to avoid having to build it everytime? TBH It's a bit tedious to wait for it 😄
This could be a later enhancement though, not for this PR.

[emmanuelbernard]

I have squasked a few Docker layers as per @gustavonalle 's comments.

@gustavonalle we could push it to Docker Hub. Caveat I am not familiar with that yet. The only thing that really chagrins me is that rake setup produces different outputs depending on Gemfile.lock, so I suspect that the same image being rebuild with a different Gemfil.lock (downloaded as part of git clone) would not be rebuilt if layer caching is enabled. But I guess that does not affect the Docker Hub vs manual build logic.

[tristantarrant]

Pushed, sir

[emmanuelbernard]

Thanks