ISPN-14646 APPEND command #10876
Merged
ISPN-14646 APPEND command #10876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karesti
requested changes
May 2, 2023
server/resp/src/test/java/org/infinispan/server/resp/RespSingleNodeTest.java
Outdated
Show resolved
Hide resolved
rigazilla
force-pushed
the
ISPN-14646
branch
5 times, most recently
from
2744c06
to
5917820
Compare
karesti
requested changes
May 2, 2023
| public CompletionStage<RespRequestHandler> perform(Resp3Handler handler, | ||
| ChannelHandlerContext ctx, | ||
| List<byte[]> arguments) { | ||
| return handler |
There was a problem hiding this comment.
check arguments size
@jabolina I think we need a general validaiton of number of arguments, what do you think ?
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.CompletionStage; | ||
|
|
||
| final class StringMutators { |
|
@rigazilla needs rebase |
karesti
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14646