ISPN-14648 GETDEL Command #10877
Merged
ISPN-14648 GETDEL Command #10877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karesti
requested changes
May 2, 2023
server/resp/src/test/java/org/infinispan/server/resp/RespSingleNodeTest.java
Outdated
Show resolved
Hide resolved
karesti
requested changes
May 2, 2023
mmm, maybe a mees with the rebase |
rigazilla
force-pushed
the
ISPN-14648
branch
2 times, most recently
from
1b63b78
to
fb477c7
Compare
|
based on #10876 for assertj |
| ChannelHandlerContext ctx, | ||
| List<byte[]> arguments) { | ||
| if (arguments.size() != getArity()-1) { | ||
| ByteBufferUtils.stringToByteBuf("-ERR wrong number of arguments for 'append' command\r\n", handler.allocatorToUse()); |
There was a problem hiding this comment.
I would centralize all -ERR strings into a Messages class using a MessageBundle (see the CLI).
There was a problem hiding this comment.
sounds good, but I would trace it in a separate issue
There was a problem hiding this comment.
| public CompletionStage<RespRequestHandler> perform(Resp3Handler handler, | ||
| ChannelHandlerContext ctx, | ||
| List<byte[]> arguments) { | ||
| if (arguments.size() != getArity()-1) { |
There was a problem hiding this comment.
formatting seems a bit off here (spaces around the subtraction)
There was a problem hiding this comment.
fixed in the APPEND PR, this depends on #10876 for assertj
wburns
approved these changes
May 4, 2023
| @@ -88,8 +89,7 @@ public String getName() { | |||
| // DEL should always be first here | |||
| indexedRespCommand[3] = new RespCommand[]{new DEL(), new DECR(), new DECRBY()}; | |||
| indexedRespCommand[4] = new RespCommand[]{new ECHO()}; | |||
| // GET should always be first here | |||
rigazilla
force-pushed
the
ISPN-14648
branch
2 times, most recently
from
c644018
to
5d33b5e
Compare
wburns
approved these changes
May 10, 2023
|
rebased, let's see... |
karesti
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14648