Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-15631 Bump org.aesh:aesh from 2.6 to 2.7 #11900

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2024

Bumps org.aesh:aesh from 2.6 to 2.7.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [org.aesh:aesh](https://github.com/aeshell/aesh) from 2.6 to 2.7.
- [Commits](https://github.com/aeshell/aesh/commits)

---
updated-dependencies:
- dependency-name: org.aesh:aesh
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

@github-actions github-actions bot changed the title Bump org.aesh:aesh from 2.6 to 2.7 ISPN-15631 Bump org.aesh:aesh from 2.6 to 2.7 Feb 1, 2024
@tristantarrant
Copy link
Member

It's green !

@tristantarrant tristantarrant added the 14.0.x Annotate a PR with this label if you want it to be backported to the 14.0.x branch label Feb 2, 2024
@@ -78,6 +79,11 @@ public Key read() throws InterruptedException {
}
}

@Override
public Key read(long timeout, TimeUnit unit) throws InterruptedException {
return read();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to worry here not abiding by the timeout? Or I guess every InputStream provided here is already completed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply mirrored what the default implementation of this does. TBH, I'm not even sure this method is being invoked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, integrating.

@wburns wburns merged commit d556637 into main Feb 2, 2024
8 checks passed
@dependabot dependabot bot deleted the dependabot/maven/org.aesh-aesh-2.7 branch February 2, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14.0.x Annotate a PR with this label if you want it to be backported to the 14.0.x branch dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
2 participants