ISPN-3108 Server compatibility minor adjustments #1828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extend keyEquivalence usage to transaction collections. * Add a getInstance() method to AnyEquivalence to provide a typesafe equivalence for any type that relies on the object's equals/hashCode() implementations. * Byte arrays can now be stored in tree bins in EquivalentCHMv8 * Achieved by making sure that the keyEquivalence's isComparable method for byte arrays returns true, and a unsigned method to compare byte arrays is implemented. * Make flag aware commands metadata aware. Makes it easier to pass down metadata information without having to do instanceof/cast of classes. * Add lifespan(long) and maxIdle(long) to Metadata builder * Use immutable metadata instance when no expiration parameters * A side effect of this is that CacheImpl does no longer extend CacheSupport because that in itself does not extend AdvancedCache and the methods defined are defined as final.
| */ | ||
| Builder lifespan(long time, TimeUnit unit); | ||
|
|
||
| /** | ||
| * Set max idle time. | ||
| * Set lifespan time assuming that the time unit is milliseconds. |
There was a problem hiding this comment.
thanks! it does simplify code a bit :-)
There was a problem hiding this comment.
Yeah, you were right. There's a lot of places where we're calling it with MILLISECONDS :)
|
thanks Galder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-3108
equivalence for any type that relies on the object's equals/hashCode()
implementations.
for byte arrays returns true, and a unsigned method to compare byte
arrays is implemented.
metadata information without having to do instanceof/cast of classes.
CacheSupport because that in itself does not extend AdvancedCache and
the methods defined are defined as final.