Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-1034 DefaultCacheManager becomes corrupted after component start Exc #257

Closed
wants to merge 2 commits into from

Conversation

maniksurtani
Copy link
Member

ISPN-1034 DefaultCacheManager becomes corrupted after component start Exception

  • Make sure volatile components are flushed and non-volatile components are rewired after a GlobalComponentRegistry.start() fails.
  • Mark CacheManagerNotifier as @SurvivesRestarts
  • Refactor nonVolatile to read survivesRestarts

Note that ISPN-1034_4 is for 4.2.x

@@ -229,7 +228,7 @@ public abstract class AbstractComponentRegistry implements Lifecycle, Cloneable
c.instance = component;
componentLookup.put(name, c);
}
c.nonVolatile = nonVolatile;
c.survivesRestarts = nonVolatile;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the nonVolatile parameter to survivesRestarts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

… Exception

* Make sure volatile components are flushed and non-volatile components are rewired after a GlobalComponentRegistry.start() fails.
* Mark CacheManagerNotifier as @SurvivesRestarts
* Refactor nonVolatile to read survivesRestarts
* GlobalComponentRegistry to throw a specific exception if failures are detected on starting up
… Exception

* Handle errors in resetting GlobalComponentRegistry
@vblagoje
Copy link

Manik, it seems that you or someone else integrated this one. I can not find the branch ISPN-1034_m and I see in the log of master that this one was integrated. Closing it.

@vblagoje vblagoje closed this Apr 23, 2011
@vblagoje
Copy link

Aha Dan integrated it. Just close the pull after you integrate it Dan. Congrats on the first integration :-)

@danberindei
Copy link
Member

Thanks Vladimir, I'll try to remember next time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants