ISPN-1034 DefaultCacheManager becomes corrupted after component start Exc #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,7 +228,7 @@ public abstract class AbstractComponentRegistry implements Lifecycle, Cloneable | |||
| c.instance = component; | |||
| componentLookup.put(name, c); | |||
| } | |||
| c.nonVolatile = nonVolatile; | |||
| c.survivesRestarts = nonVolatile; | |||
There was a problem hiding this comment.
Rename the nonVolatile parameter to survivesRestarts?
… Exception * Make sure volatile components are flushed and non-volatile components are rewired after a GlobalComponentRegistry.start() fails. * Mark CacheManagerNotifier as @SurvivesRestarts * Refactor nonVolatile to read survivesRestarts * GlobalComponentRegistry to throw a specific exception if failures are detected on starting up
… Exception * Handle errors in resetting GlobalComponentRegistry
|
Manik, it seems that you or someone else integrated this one. I can not find the branch ISPN-1034_m and I see in the log of master that this one was integrated. Closing it. |
|
Aha Dan integrated it. Just close the pull after you integrate it Dan. Congrats on the first integration :-) |
|
Thanks Vladimir, I'll try to remember next time :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISPN-1034 DefaultCacheManager becomes corrupted after component start Exception
Note that ISPN-1034_4 is for 4.2.x