Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-4306 Properly create the RealmUser when obtaining credentials over GSSAPI #2578

Conversation

tristantarrant
Copy link
Member

@galderz
Copy link
Member

galderz commented Jun 2, 2014

@tristantarrant Compilation error on CI:

[22:11:47][org.infinispan.server:infinispan-server-endpoints] [ERROR] /mnt/ebs/TeamCity/buildAgent/work/c8db63ad778e4d73/server/integration/integration/src/main/java/org/infinispan/server/endpoint/subsystem/RealmSubjectUserInfo.java:[20,58] package org.jboss.as.core.security does not exist
[22:11:47][org.infinispan.server:infinispan-server-endpoints] [ERROR] /mnt/ebs/TeamCity/buildAgent/work/c8db63ad778e4d73/server/integration/integration/src/main/java/org/infinispan/server/endpoint/subsystem/RealmSubjectUserInfo.java:[20,58] package org.jboss.as.core.security does not exist

@tristantarrant
Copy link
Member Author

This needs the WildFly pull to happen

On Mon, Jun 2, 2014 at 10:21 AM, Galder Zamarreño notifications@github.com
wrote:

@tristantarrant https://github.com/tristantarrant Compilation error on
CI:

[22:11:47][org.infinispan.server:infinispan-server-endpoints] [ERROR] /mnt/ebs/TeamCity/buildAgent/work/c8db63ad778e4d73/server/integration/integration/src/main/java/org/infinispan/server/endpoint/subsystem/RealmSubjectUserInfo.java:[20,58] package org.jboss.as.core.security does not exist
[22:11:47][org.infinispan.server:infinispan-server-endpoints] [ERROR] /mnt/ebs/TeamCity/buildAgent/work/c8db63ad778e4d73/server/integration/integration/src/main/java/org/infinispan/server/endpoint/subsystem/RealmSubjectUserInfo.java:[20,58] package org.jboss.as.core.security does not exist


Reply to this email directly or view it on GitHub
#2578 (comment)
.

@galderz
Copy link
Member

galderz commented Jun 9, 2014

Needs rebasing...

@tristantarrant
Copy link
Member Author

Rebased

@galderz
Copy link
Member

galderz commented Jun 9, 2014

Let's integrate #2579 first then and make sure the test is fixes...

@galderz
Copy link
Member

galderz commented Jun 12, 2014

Rebase

@tristantarrant
Copy link
Member Author

Rebased

@@ -146,6 +146,9 @@
@Message(id = 10021, value = "Invalid Strength value: %s")
IllegalStateException invalidStrength(String strengthValue);

@Message(id = 10022, value = "Endpoint '%s' requires Client Certificates, but no Trust Store is available in realm '%s'")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you keep the old id in the old message and set the new id to the new message?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That id was mistakenly introduced during the 7.0.0.Alpha cycle, so I'm aligning against the product so that we remain consistent.

@pruivo
Copy link
Member

pruivo commented Jun 26, 2014

just a small comment:

  • do we have a test for this?
  • still doesn't compile
[ERROR] /ssd/pedro/IdeaProjects/infinispan/server/integration/endpoint/src/main/java/org/infinispan/server/endpoint/subsystem/EndpointServerAuthenticationProvider.java:[18,47] cannot find symbol
[ERROR] symbol:   class RealmUser
[ERROR] location: package org.jboss.as.domain.management.security
(etc....)

@tristantarrant
Copy link
Member Author

Updated, now it compiles. The test is HotRodKrbAuthIT.java but it won't work until #2664 has been merged too

@pruivo
Copy link
Member

pruivo commented Jun 26, 2014

hmmm so it is better to wait for #2664

@galderz
Copy link
Member

galderz commented Jul 14, 2014

#2664 has been integrated now

@tristantarrant
Copy link
Member Author

rebased

@galderz
Copy link
Member

galderz commented Jul 21, 2014

Integrated

@galderz galderz closed this Jul 21, 2014
@tristantarrant tristantarrant deleted the ISPN-4306/gssapi_realmuser branch October 30, 2014 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants