New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-4177 Upgrade to WildFly 8.1.0.Final #2579
Conversation
ALL IN ONE COMMIT? Now I understand the jokes on IRC this morning :-) |
More seriously: there is some practical value in making sure that git actually is able to recognize when you're moving files. If you do, you're not just making review far easier but also future merges, bisects and rebases will work flawlessly rather than producing a huge red conflict. |
@tristantarrant CI failed with:
|
@Sanne actually git locally does mark all the files as moved, so I don't know if it's github getting it wrong. The actual payload of this PR is quite small, with lots of noise. Here is the breakdown
|
@galderz fixed |
@mgencur I have made some minor adjustments to the integration testsuite but I'm not sure I've done everything that is needed. Note the upgrade of a bunch of subsystem schemas. |
The server test suite needs several changes and I'm working on it:
|
So the exception I was getting is caused by the fact that ISPN server now pulls in org/hibernate/hql/lucene/hibernate-hql-lucene-1.0.0.Alpha6.jar - this is wrong, it should be 1.0.0.CR1 |
@tristantarrant Right, github UI is not as smart as a local git inspection, still in such scenarios I think a sequence of specific commits is easier to handle (and maintain and understand). @mgencur from that exception it looks like it's using the old hql-lucene parser, you need 1.0.0.CR1 |
We were still "importing" infinispan-bom instead of infinispan-parent (which inherits from bom) thus wildfly-parent (which we are also importing) was overriding the hql parser version. Fixed |
Here's the commit that fixes the server test suite. You can add it to this PR: mgencur@a31d04e I released a new version of Infinispan Arquillian project (1.2.0.Alpha1) and updated server test suite to use it. |
One more problem with dependencies: LevelDB cache store depends on org.iq80.leveldb:leveldb:jar:0.5 but the server (after the rebase) contains version 0.6. So currently the test for LevelDB fails. |
Pulled in @mgencur 's test fixes and removed the spurious leveldb dep from server/integration/versions/pom.xml |
@tristantarrant CI run on Friday, shows the error I mentioned above, but for a different project:
|
Also needs rebasing |
Rebased and fixed the parallel parameter |
Oh, and WildFly 8.1.0.Final is out |
Rebasing needed... |
Also, the last build did not succeed, failed with:
|
Rebased |
Integrated, thanks @tristantarrant :) |
https://issues.jboss.org/browse/ISPN-4177
Big Effing Commit