-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-4323 ConditionalOperationsConcurrentWriteSkewTest fails randomly #2804
Conversation
I moved the various tests to the stress package as they can be lead to quite a few false positives while other tests are running. If you don't like that let me know. |
@wburns I'd rather keep the "simple" tests in the original files and create ConditionalOperationsConcurrent*StressTest for the ones with 500 iterations. |
Sure, the other thing I was quite sure on is that only the write skew has a simple test implementation currently. Do we want to have simple tests for the others as well? Maybe I should log a JIRA? |
Yeah, l think we want simple tests for the others as well. Another option would be to duplicate the tests we have now, only the functional test would have less threads/iterations and the stress test would have more threads/iterations. |
Sure I can do it that way as well. |
I almost forgot we should probably do the same with |
Yeah I was planning on getting to all the classes that extend ConditionalOperationsTest including it. |
Oops, I meant |
:) |
Actually you were are right I was thinking of ConditionalOperationsConcurrentTest, thanks. |
Updated with new test classes. |
@wburns I would change the author and since from the new classes :) |
testOnCaches(caches, new ConditionalRemoveOperation(false)); | ||
} | ||
|
||
public void testPutIfAbsent() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing @Override
* Changed 500 invocation tests to stress as they can last for minutes * Moved more simple test to separate file and still functional
Updated comments and rebased. Also regarding the author tags and version: I added my author tag to the new classes but left the original one, since these new classes are just using the previous one essentially and I added 7.0 version to the new ones. |
* | ||
* @author Sanne Grinovero <sanne@infinispan.org> (C) 2012 Red Hat Inc. | ||
* @author William Burns | ||
* @see java.util.concurrent.ConcurrentMap#replace(Object, Object, Object) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why see the replace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is on the original Test class when I copied it over, TBH I had removed it for a sec but kept it just because the other one had it.
I am fine with removing if you want. I also thought of adding the other methods as well, but I didn't really mind either way, heh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, leave it... I'm already started to run the test suite
integrated! thanks @wburns ! |
Funny thing, this PR effectively disabled those tests. In |
#4625 should re-enable the test |
https://issues.jboss.org/browse/ISPN-4323