ISPN-4753 Add oldValue, oldMetadata and retry flag to filter and convert... #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @author wburns | ||
| * @since 7.0 | ||
| */ | ||
| public enum EventType { |
There was a problem hiding this comment.
This enum has become a bit complicated, I am thinking maybe I should change over to a regular class. WDYT?
| @@ -27,20 +27,20 @@ | |||
| * Notifies all registered listeners of a CacheEntryCreated event. | |||
| */ | |||
| void notifyCacheEntryCreated(K key, V value, boolean pre, | |||
| InvocationContext ctx, FlagAffectedCommand command); | |||
| InvocationContext ctx, FlagAffectedCommand command, InternalCacheEntry<K, V> previousEntry); | |||
There was a problem hiding this comment.
I am thinking of changing these to instead take an Object and Metadata directly so we don't need to clone the Entry and it should work for pre events easier as we won't have an Entry there either.
wburns
force-pushed
the
ISPN-4753
branch
2 times, most recently
from
469dbed
to
7908ed3
Compare
|
Fixed the comments I had before. |
wburns
force-pushed
the
ISPN-4753
branch
2 times, most recently
from
18127c3
to
ed59e59
Compare
|
Fixing a few test failures and will update. |
wburns
force-pushed
the
ISPN-4753
branch
2 times, most recently
from
31674f1
to
68c657c
Compare
…erter for Cluster Listeners. * Added new filter and converter specifically for listeners
|
Tests should be fixed, had some references that were missed when I rebased and fixed conflicts. |
|
Integrated, thanks Will! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...er for
Cluster Listeners.
https://issues.jboss.org/browse/ISPN-4753