Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-5023 Random Failues on *FactoryBeanTest in the Spring Modules #3107

Merged
merged 1 commit into from Nov 26, 2014

Conversation

gustavocoding
Copy link

https://issues.jboss.org/browse/ISPN-5023

Wasn't able to reproduce it locally, but I think sometimes there's a clash inside Jgroups Jmx registration, given that the modules run by default on 15 threads. Changed it to 1 Thread, test time is roughly the same in my environment

@anistor
Copy link
Member

anistor commented Nov 26, 2014

Looking..

@danberindei
Copy link
Member

I don't think we should be calling JGroups' JmxConfigurator.registerChannel(), at least not with a global server.

@anistor anistor merged commit 2519083 into infinispan:master Nov 26, 2014
@anistor
Copy link
Member

anistor commented Nov 26, 2014

Integrated. Thanks @gustavonalle !

@gustavocoding gustavocoding deleted the spring_tests branch November 26, 2014 13:44
@gustavocoding
Copy link
Author

I don't think we should be calling JGroups' JmxConfigurator.registerChannel()

@danberindei Why shouldn't it be called with a global server? Looking at the javadoc for this method: Registers an already created channel with the given MBeanServer.

@danberindei
Copy link
Member

@gustavonalle I thought TestCacheManagerFactory took care of creating a separate MBean server for each test thread, but I see I was wrong and it only sets a unique domain name.

Looks like the ISPN-3125 fix replaced the call to AbstractEmbeddedCacheManagerFactory.createCacheManager(InputStream is) with a direct new DefaultCacheManager, and the domain isn't renamed. I've created #3108 to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants