ISPN-5023 Random Failues on *FactoryBeanTest in the Spring Modules #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danberindei
force-pushed
the
t_ISPN-5023_duplicateDomain
branch
from
fb65b15
to
10282d2
Compare
|
Looking |
| protected EmbeddedCacheManager createCacheManager(InputStream is) throws IOException { | ||
| return TestCacheManagerFactory.fromStream(is); | ||
| protected EmbeddedCacheManager createCacheManager(ConfigurationBuilderHolder configurationBuilderHolder) { | ||
| return TestCacheManagerFactory.createClusteredCacheManager(configurationBuilderHolder); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
TestSpringEmbeddedCacheManagerFactoryBean is not used it seems
Remove the test cache manager factories and test the production ones directly.
danberindei
force-pushed
the
t_ISPN-5023_duplicateDomain
branch
from
10282d2
to
dd0da31
Compare
|
I removed both test factories. |
|
Merged. Thanks @danberindei |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force the test JMX domain even if the configuration was loaded from a file.
https://issues.jboss.org/browse/ISPN-5023