-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-5084 Eclipse compilation errors for modules dependent on uberjars #3168
Conversation
Any other ideas on how to resolve this? This solution works but there might be a cleaner approach... |
SUCCESS - TeamCity Infinispan :: Pull requests monitor Build 8084/isavin:ISPN-5084_eclipse_build_fix_uberjar_dependencies for 7238ba4 |
Looks ok to me, maybe someone who actually uses Eclipse could look at it? |
FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8110/isavin:ISPN-5084_eclipse_build_fix_uberjar_dependencies for 7238ba4 Failed tests detected
Error message is logged Process exited with code 1 |
FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8116/isavin:ISPN-5084_eclipse_build_fix_uberjar_dependencies for 7238ba4 Failed tests detected
|
FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8167/isavin:ISPN-5084_eclipse_build_fix_uberjar_dependencies for 7238ba4 Failed tests detected
Error message is logged Build duration (secs) is too large: 6768 |
SUCCESS - TeamCity Infinispan :: Pull requests monitor Build 8183/isavin:ISPN-5084_eclipse_build_fix_uberjar_dependencies for 7238ba4 |
FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8193/isavin:ISPN-5084_eclipse_build_fix_uberjar_dependencies for 7238ba4 Failed tests detected
Error message is logged Build duration (secs) is too large: 7832 |
FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8221/isavin:ISPN-5084_eclipse_build_fix_uberjar_dependencies for 7238ba4 Failed tests detected
Error message is logged Build duration (secs) is too large: 6788 |
Created a profile for Eclipse which marks uberjar dependencies as non-optional.
Rebased. |
FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8236/isavin:ISPN-5084_eclipse_build_fix_uberjar_dependencies for d7a5f32 Failed tests detected
Error message is logged Build duration (secs) is too large: 6713 |
FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8266/isavin:ISPN-5084_eclipse_build_fix_uberjar_dependencies for d7a5f32 Failed tests detected
Error message is logged Build duration (secs) is too large: 6870 |
FAILURE - TeamCity Infinispan :: Pull requests monitor Build 8286/isavin:ISPN-5084_eclipse_build_fix_uberjar_dependencies for d7a5f32 Failed tests detected
|
Checking... |
Looks good, removed over 490 compilation errors :) Pulling... |
Integrated into master, thanks @isavin ! |
Created a profile for Eclipse which marks uberjar dependencies as non-optional.
https://issues.jboss.org/browse/ISPN-5084