ISPN-5477 Too agressive unboxing leading to wrong L1 returns #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CompatibilityCacheFactory.killCacheFactories(cacheFactory1, cacheFactory2); | ||
| } | ||
|
|
||
| // public void testHotRodPutInNonOwner() { |
There was a problem hiding this comment.
Are we adding this back in? If not we can remove the SplitMagicKey class it seems.
There was a problem hiding this comment.
There seems to be an overlap in functionality between getSplitIntKeyForServer and SplitMagicKey anyway...
There was a problem hiding this comment.
Leftover stuff, I'll clean it up and update.
galderz
force-pushed
the
t_5477
branch
2 times, most recently
from
fb177d7
to
cdced1a
Compare
* Unboxing of entries for external client consumption should only happen when commands are local, since remote commands come from internal clustering.
|
Updated |
|
Integrated, thanks Galder! |
|
And now in 7.2.x as well. |
|
@danberindei @galderz I'm not sure what the problem is but it seems these changes cause the tests to hang on master. Reverting them fixes the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-5477