-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-5345 Allow eviction for based on approximation of size compared to element count #3492
Conversation
@tristantarrant I liked your previous suggestion much better... I'd rather have two different attributes/elements with clear names than a generic To add yet another suggestion: How about deprecating the |
Supporting that for embedded is reasonable, it is server which always causes head-scratching and pain, since we need to think about how to represent those "nodes" in the management model in a non ambiguous way |
@danberindei using type and size now |
CI failures are unrelated |
@@ -66,6 +66,7 @@ | |||
MAX_IDLE("max-idle"), | |||
MAX_RETRIES("max-retries"), | |||
MAX_THREADS("max-threads"), | |||
MEMORY_BASED_APPROXIMATION("memory-based"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove these
They are gone |
} | ||
|
||
public EvictionType thresholdPolicy() { | ||
return type.get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be size()
and type()
Silly, me, fixed now |
element count * Added in size calculation for byte[] key/value pairs with LRU
Integrated, thanks Tristan! |
https://issues.jboss.org/browse/ISPN-5345
This supersedes' @wburns #3467 and introduces the following changes: