ISPN-5682 Aggregating fields of embedded entities doesn't work #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking |
|
@gustavonalle Just found issues with some tests. |
| @@ -181,6 +183,108 @@ private BaseQuery buildQueryWithAggregations(QueryFactory queryFactory, String j | |||
|
|
|||
| // validity of query is established at this point, no more checks needed | |||
|
|
|||
| boolean foundAggregationsOnRepeatedFields = false; | |||
There was a problem hiding this comment.
I plan to extract this blob into a method.
anistor
force-pushed
the
t_5682_m
branch
2 times, most recently
from
1f4e621
to
4f1eccd
Compare
|
Updated. |
|
There's only 1 failure left at |
|
Fixed. |
|
pulling |
|
integrated, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.jboss.org/browse/ISPN-5682