ISPN-6046 Server Rolling Upgrade performance improvement #3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } else { | ||
| final AtomicInteger count = new AtomicInteger(0); | ||
| ExecutorService executorService = Executors.newFixedThreadPool(threads); |
There was a problem hiding this comment.
for consistency, use the same naming for the ExecutorService variable as above (es/executorService)
gustavocoding
force-pushed
the
rolling_upgrade
branch
4 times, most recently
from
558c6b2
to
452ee9b
Compare
added 8 commits
January 12, 2016 18:12
…he source cluster
gustavocoding
force-pushed
the
rolling_upgrade
branch
from
452ee9b
to
72d0346
Compare
|
@ttarrant Updated. I also had to change the architecture a little bit to maintain the "advertised" performance, since |
|
Good job, @gustavonalle . Merged |
|
Brilliant work @gustavonalle 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-6046
https://issues.jboss.org/browse/ISPN-6052
https://issues.jboss.org/browse/ISPN-6053
https://issues.jboss.org/browse/ISPN-6064
https://issues.jboss.org/browse/ISPN-6065
Perf
Before: Rolling upgrade from clusters 8.1.0.Final (2 members) -> 8.1.0.Final (2 members)
(times are the sum of time to dump keys plus the time to synchronize data)
After: Rolling upgrade from clusters 8.2.0-SNAPSHOT (2 members) -> 8.2.0-SNAPSHOT (2 members)
(no key dump is necessary if the source cluster is ispn >= 8.0)
benchmark hardware: 8Gb RAM, 4 vCPU, Fedora 22 on Openstack
Details
This PR makes use of the Remote Iterator to migrate data between clusters, the dumpKeys step is not necessary if the source cluster has version >= 8.0. If not, it will fallback to reading keys dumped.