ISPN-7989 Fixed Spring remote test #5256
Conversation
| hcb.port(15233); | ||
| hotrodServer = HotRodClientTestingUtil.startHotRodServer(cacheManager, hcb); | ||
| hcb.port(PORT); | ||
| hotrodServer = HotRodClientTestingUtil.startHotRodServer(cacheManager, PORT, hcb); |
There was a problem hiding this comment.
FYI, HotRodClientTestingUtil.startHotRodServer(cacheManager, hcb) will pick a free port
There was a problem hiding this comment.
No, the 2 argument #startHotRodServer does that. That's why this test was broken :(
There was a problem hiding this comment.
Nevermind, I was about to suggest not to hardcode the port in the test, but rely in the free port discovered, but I now see this test uses a properties file
There was a problem hiding this comment.
@slaskawi I suppose we'll never have enough Spring tests to make it worth running in parallel, so a fixed port should be fine. But instead of hard-coding the port here, I would inject the properties file and parse the port from the infinispan.client.hotrod.server_list property.
There was a problem hiding this comment.
@danberindei +1. But I'd prefer to do it in a separate JIRA (so I created ISPN-8017)
|
Apparently this issue has been already fixed by 1a3d653#diff-5af2436e9ce44e0c2a8f7d448537bb96L50. Thanks @tristantarrant! |
https://issues.jboss.org/browse/ISPN-7989