ISPN-8712 BiasRevocationTest.testFailedRevocationDuringPutAllOnNonOwn… #5692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erThrowBefore random failures * Avoid NullPointerException in EntryWrappingInterceptor when resetting the context entries for a retried command. * Wrap triangle ACK exceptions on the originator * Use the same logic as for synchronous commands, preserving OutdatedTopologyExceptions.
rvansa
reviewed
Jan 22, 2018
| @@ -17,6 +21,7 @@ | |||
| * @since 9.0 | |||
| */ | |||
| public class ExceptionAckCommand extends BaseRpcCommand { | |||
| private static final Log log = LogFactory.getLog(ExceptionAckCommand.class); | |||
There was a problem hiding this comment.
Forgot about this comment, sorry.
There was a problem hiding this comment.
Me too, I've checked just tests and merged... let's not worry about that.
| @@ -235,7 +234,7 @@ private BlockingRunnable createIndirectRpcRunnable(SingleRpcCommand command, int | |||
| return new DefaultTopologyRunnable(this, command, Reply.NO_OP, TopologyMode.READY_TX_DATA, commandTopologyId, false) { | |||
| @Override | |||
| protected void onException(Throwable throwable) { | |||
| sendExceptionAck(writeCommand.getCommandInvocationId(), new RemoteException("Exception on " + localAddress, throwable), commandTopologyId); | |||
| sendExceptionAck(writeCommand.getCommandInvocationId(), throwable, commandTopologyId); | |||
There was a problem hiding this comment.
Did you have any reason to drop the RemoteException wrapping? I probably found useful having the address of exception source at hand...
There was a problem hiding this comment.
Except for OutdatedTopologyException and AvailabilityException, the wrapping still happens.
danberindei
deleted the
ISPN-8712_EntryWrappingInterceptor_NullPointerException
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erThrowBefore random failures
https://issues.jboss.org/browse/ISPN-8712
when resetting the context entries for a retried command.
OutdatedTopologyExceptions.