New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-8712 BiasRevocationTest.testFailedRevocationDuringPutAllOnNonOwn… #5692
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,6 @@ | |
import org.infinispan.factories.annotations.Inject; | ||
import org.infinispan.factories.annotations.Start; | ||
import org.infinispan.interceptors.locking.ClusteringDependentLogic; | ||
import org.infinispan.remoting.RemoteException; | ||
import org.infinispan.remoting.inboundhandler.action.Action; | ||
import org.infinispan.remoting.inboundhandler.action.ActionState; | ||
import org.infinispan.remoting.inboundhandler.action.ActionStatus; | ||
|
@@ -235,7 +234,7 @@ private BlockingRunnable createIndirectRpcRunnable(SingleRpcCommand command, int | |
return new DefaultTopologyRunnable(this, command, Reply.NO_OP, TopologyMode.READY_TX_DATA, commandTopologyId, false) { | ||
@Override | ||
protected void onException(Throwable throwable) { | ||
sendExceptionAck(writeCommand.getCommandInvocationId(), new RemoteException("Exception on " + localAddress, throwable), commandTopologyId); | ||
sendExceptionAck(writeCommand.getCommandInvocationId(), throwable, commandTopologyId); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you have any reason to drop the RemoteException wrapping? I probably found useful having the address of exception source at hand... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Except for |
||
} | ||
}; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot about this comment, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too, I've checked just tests and merged... let's not worry about that.