ISPN-8918 When a cache is stopped and restarted, its configuration re… #5817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ference within component registry is not refreshed with defineConfiguration/undefineConfiguration
|
Hey @tristantarrant since you did the intial implementation for undefining caches (https://issues.jboss.org/browse/ISPN-5033) you might want to take a look. Thx! |
|
@rhusar, looks good. What implementation of ISPN-5033? You mean ISPN-8918? |
|
Too late @pferraro, too late :-) |
|
@galderz I did mean the original author of underfineConfiguration, so yes https://issues.jboss.org/browse/ISPN-5033 -- thanks for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ference within component registry is not refreshed with defineConfiguration/undefineConfiguration
When a cache is stopped and restarted, its configuration reference within component registry is not refreshed with defineConfiguration/undefineConfiguration.
The problem is that org/infinispan/factories/ComponentRegistry.java:77 is only called once the cache is being wired thus registerComponent(configuration, Configuration.class); is the only place where the configuration is put into the registry.
The best solution is to remove the cache in TERMINATED state once configuration is undefined thus establishing a clear terminal lifecycle.
Jira
https://issues.jboss.org/browse/ISPN-8918
Workaround is possible in wildfly, so not urgent.