Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-9045 Failure to change 'protocolVersion' in RemoteStoreConfigura… #5907

Closed
wants to merge 1 commit into from
Closed

ISPN-9045 Failure to change 'protocolVersion' in RemoteStoreConfigura… #5907

wants to merge 1 commit into from

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Apr 10, 2018

@tristantarrant
Copy link
Member

Well, it does work if you use "PROTOCOL_VERSION_27", but it ain't pretty. Can you please also add a test to

infinispan/persistence/remote/src/test/java/org/infinispan/persistence/remote/configuration/ConfigurationTest.java

Line 10 in f073832

public void testRemoteCacheStoreConfigurationAdaptor() {
?
Ideally we should be able to use the same property names that the Hot Rod client ConfigurationBuilder supports... but that is for another time

@tristantarrant
Copy link
Member

Added a test and merged as 59d291e

@rhusar
Copy link
Member Author

rhusar commented Apr 11, 2018

Thanks @tristantarrant for handling this (I was on PTO yesterday).

@rhusar rhusar deleted the ISPN-9045 branch April 11, 2018 07:36
@rhusar rhusar mentioned this pull request Apr 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rhusar @tristantarrant