ISPN-10059 Off-heap clustered cache cannot start with segmentation di… #6779
Conversation
danberindei
force-pushed
the
ISPN-10059_offheapdatacontainer
branch
from
aec758c
to
d74de76
Compare
…sabled * Implement addSegments/removeSegments in OffHeapDataContainer and BoundedOffHeapDataContainer * Use the InternalDataContainerAdapter implementation in all non-segmented InternalDataContainer implementations * Only retry the join request on failure * Skip tests that require segmentation when the feature is disabled
danberindei
force-pushed
the
ISPN-10059_offheapdatacontainer
branch
from
d74de76
to
9db8bac
Compare
|
Updated to fix the retry, override InternalDataContainer methods in BoundedOffHeapDataContainer, and skip tests that require segmentation when the feature is disabled. There's still a failure in ExpirationSingleFileStoreDistListenerFunctionalTest that might be related. Please run test suite with |
| @@ -57,4 +75,88 @@ public boolean containsKey(Object k) { | |||
| public void evict(WrappedBytes key) { | |||
| super.evict(0, key); | |||
| } | |||
|
|
|||
| @Override | |||
| public void put(WrappedBytes key, WrappedBytes value, Metadata metadata) { | |||
There was a problem hiding this comment.
I wish this wasn't required, that we could reuse AbstractInternalDataContainer instead. But unfortunately these classes were written assuming they wouldn't be called in the wrong context, so I am fine with it.
I can confirm it consistently fails for me as well. |
|
Integrated into master, thanks @danberindei ! |
|
We still need a JIRA for max idle expiration being available in iteration for non segmented containers in a cluster. |
|
I created https://issues.jboss.org/browse/ISPN-10074, although when I created it I thought the problem was with the segmented containers returning expired entries. |
…sabled
https://issues.jboss.org/browse/ISPN-10059
non-segmented InternalDataContainer implementations