Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-9457 ISPN-10180 Async Cross-Site Features #6907

Merged
merged 1 commit into from
May 17, 2019
Merged

ISPN-9457 ISPN-10180 Async Cross-Site Features #6907

merged 1 commit into from
May 17, 2019

Conversation

pruivo
Copy link
Member

@pruivo pruivo commented May 13, 2019

  • async replication time
  • automatically take a site offline

@pruivo pruivo force-pushed the t_async_xsite_offline branch 2 times, most recently from 9e0fed0 to 210cb06 Compare May 14, 2019 09:24
karesti
karesti requested changes May 17, 2019
View reviewed changes
Copy link
Contributor

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

core/src/main/java/org/infinispan/remoting/rpc/RpcManagerImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/infinispan/remoting/transport/jgroups/JGroupsBackupResponse.java Show resolved Hide resolved
core/src/main/java/org/infinispan/remoting/transport/jgroups/JGroupsBackupResponse.java Show resolved Hide resolved
core/src/main/java/org/infinispan/xsite/BackupSenderImpl.java Show resolved Hide resolved
core/src/test/java/org/infinispan/jmx/RpcManagerMBeanTest.java Show resolved Hide resolved
@pruivo
ISPN-9457 ISPN-10180 Async Cross-Site Features
f0e1c68 
* async replication time
* automatically take a site offline
@pruivo
Copy link
Member Author

pruivo commented May 17, 2019

updated

karesti
karesti approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Pedro, do you need any additional review from anyone else?

@pruivo
Copy link
Member Author

pruivo commented May 17, 2019

@karesti feel free to integrate it :)

@karesti karesti merged commit 15c77fd into infinispan:master May 17, 2019
@karesti
Copy link
Contributor

karesti commented May 17, 2019

@pruivo integrated thanks! I let you handle all the JIRA related stuff 👯

@pruivo
Copy link
Member Author

pruivo commented May 17, 2019

thanks @karesti

@pruivo pruivo deleted the t_async_xsite_offline branch July 5, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karesti karesti karesti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pruivo @karesti