ISPN-9590 ExtendedSearchWorkCreator and SearchWorkCreatorContext are … #7719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anistor
force-pushed
the
t_remove_ExtendedSearchWorkCreator_m
branch
2 times, most recently
from
ade4b4d
to
6cd203b
Compare
|
Once this runs in CI we'll need to backport to 9.4.x a subset of the changes (only the move to cacheStarting) @gustavonalle |
|
I found a couple of issues in the reproducer:
I am fixing 1) and adding a TX test to it. BTW, at least on 9.4, even with this fix TX caches don't index during State Transfer... |
anistor
force-pushed
the
t_remove_ExtendedSearchWorkCreator_m
branch
from
12f104b
to
6dd8beb
Compare
|
FYI, I added TX to the reproducer, and it fails on 9.4.x even with the lifecycle fix. This is probably a separate problem not related to registry but still should fall under this JIRA c477dc6 |
anistor
force-pushed
the
t_remove_ExtendedSearchWorkCreator_m
branch
2 times, most recently
from
bcaf9df
to
001837a
Compare
…no longer needed * remove them now * also deprecate SearchWorkCreator and remove DefaultSearchWorkCreator * SearchWorkCreator will be entirely removed once we migrate to HS 6
* move creation of ProtobufValueWrapperSearchWorkCreator to cacheStarting event
anistor
force-pushed
the
t_remove_ExtendedSearchWorkCreator_m
branch
from
001837a
to
b43121a
Compare
|
CI looks good. |
|
Merged, thanks @anistor ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…no longer needed
https://issues.redhat.com/browse/ISPN-9590
https://issues.redhat.com/browse/ISPN-11132
The fix includes relevant stuff from #7725