ISPN-1801 - Virtual nodes should be enabled by default #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,72 @@ | |||
| Generated with VNodesKeyDistributionTest | |||
There was a problem hiding this comment.
Why is the output for 48 an 64 nodes missing?
|
@Sanne I wanted to keep the existing behaviour - all I needed was to reduce the number of calls to LogFactory.getLog() to make my test go faster. I think we had a discussion about not logging subclass names on the mailing list, but I don't remember if we reached a conclusion... |
I set the default number of virtual nodes to 48. I added a test for key distribution with various numbers of virtual nodes, 48 seems to be a reasonable default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-1801
Also t_1801_51 for the 5.1.x branch.
I set the default number of virtual nodes to 48.
I added a test for key distribution with various numbers of virtual nodes,
48 seems to be a reasonable default.