ISPN-13121 Cache persistent state is not deleted after restart #9399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danberindei
commented
Jun 24, 2021
| // Can wait on lock | ||
| builder.allowBlockingCallsInside(ClusterTopologyManagerImpl.class.getName(), "updateState"); | ||
|
|
||
| // These methods to I/O via GlobalStateManager |
There was a problem hiding this comment.
@wburns I've been thinking about excluding all the GlobalStateManagerImpl methods here instead of their callers, WDYT?
There was a problem hiding this comment.
Sure, more specific is better :)
There was a problem hiding this comment.
I will take a look a the methods to see if we should have a JIRA or not to convert the methods instead of just an exclusion.
There was a problem hiding this comment.
Sure if just excluding the file reading at GlobalStateManagerImpl works, then I am all for it.
|
LGTM. |
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-13121