update protobuf example #9479
update protobuf example #9479
Conversation
| configurations | ||
| schemas | ||
| tasks | ||
| [//containers/default]> ls |
There was a problem hiding this comment.
Thanks for the contribution @Scuilion, but I'm not sure if this change is correct. I believe the intent of the original example is to change to the caches/___protobuf_metadata] context and then display all registered *.proto files. Your addition simply shows the result of executing ls in the root context, which isn't necessary to verify the presence of person.proto.
\cc @oraNod
There was a problem hiding this comment.
Indeed, thanks for the contribution @Scuilion! Ryan is correct in that the current change you're suggesting doesn't actually verify person.proto. That said the verification step does need to change because it was written before the schemas directory existed. ___protobuf_metadata is still there, but is hidden.
We could change this to cd schemas then ls which shows all the Protobuf schema files.
| configurations | ||
| schemas | ||
| tasks | ||
| [//containers/default]> ls |
There was a problem hiding this comment.
Indeed, thanks for the contribution @Scuilion! Ryan is correct in that the current change you're suggesting doesn't actually verify person.proto. That said the verification step does need to change because it was written before the schemas directory existed. ___protobuf_metadata is still there, but is hidden.
We could change this to cd schemas then ls which shows all the Protobuf schema files.
documentation/src/main/asciidoc/topics/proc_cli_registering_protobuf_schema.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/topics/proc_cli_registering_protobuf_schema.adoc
Outdated
Show resolved
Hide resolved
…otobuf_schema.adoc Co-authored-by: Don Naro <dnaro@redhat.com>
…otobuf_schema.adoc Co-authored-by: Don Naro <dnaro@redhat.com>
|
Thanks for the feedback. What is the process of updating a PR? Do I need to create a new PR with a single commit? Squash the commits that are here? |
@Scuilion No need for a separate PR. I'll just squash and merge and add a commit message. Thanks for the docs contribution! |
Docs revision: CLI and contributor guide updates
Just a slight update to documentation.
If this needs a jira ticket I'm happy to create one.