Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting width on text container view for wrapping #222

Merged
merged 2 commits into from
May 10, 2023

Conversation

morganick
Copy link
Contributor

@morganick morganick commented May 10, 2023

Description

Trello Card
Fixes #216

Setting the text container width so that the text will wrap properly. I'm not exactly sure as to why it isn't pulling the width from the container, but I have a feeling this will be more obvious when I refactor this into a ScreenTab component.

Note: Volume indicator is not relevant to the after screenshot. It's just there to show that I failed to take the screenshot the first time with one hand. I'm getting better at it, but more practice is evidently required. 😜

Graphics

Before After
Screenshot_20230510_154247_Chain React App 2023 Screenshot_20230510_153508_Chain React App 2023

Checklist:

  • I have done a thorough self-review of my code
  • I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • I have run tests and linter

@morganick morganick self-assigned this May 10, 2023
@morganick morganick added the bug Something isn't working label May 10, 2023
@morganick morganick marked this pull request as ready for review May 10, 2023 19:56
@morganick morganick merged commit 6653b72 into main May 10, 2023
@morganick morganick deleted the fix/216-accessible-workshop-banner branch May 10, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events workshop banner unreadable with larger text sizes
2 participants