This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Quell storybook HMR warnings #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Storybook fix for this issue storybookjs/storybook#1525 adds a warning when `storiesOf` doesn’t have a `module` parameter. The `module` parameter is necessary to enable hot-module-replacement to work right: storybookjs/storybook#2022 (comment)
infinitered-circleci
pushed a commit
that referenced
this pull request
Apr 9, 2019
# [3.1.0](v3.0.0...v3.1.0) (2019-04-09) ### Bug Fixes * **boilerplate:** Remove double slash typo on setup-root-store.ts ([#160](#160) by [@dashracer](https://github.com/dashracer)) ([941a1fe](941a1fe)) * **tests:** Quell storybook HMR warnings ([#149](#149) by [@bryanstearns](https://github.com/bryanstearns)) ([5663289](5663289)), closes [/github.com/storybookjs/storybook/issues/2022#issuecomment-336027878](https://github.com//github.com/storybooks/storybook/issues/2022/issues/issuecomment-336027878) * **typescript:** TypeScript should apply to `app` instead of `src` ([#167](#167) by [@guhungry](https://github.com/guhungry)) ([b737f08](b737f08)) ### Features * **i18n:** Migrate to react-native-localize ([#165](#165) by [@guhungry](https://github.com/guhungry)) ([2c73ff4](2c73ff4)) * **mobx:** Update to mobx-state-tree version 3.12.2 ([#166](#166) by [@guhungry](https://github.com/guhungry)) ([7911213](7911213))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Storybook fix for this issue storybookjs/storybook#1525
adds a warning when
storiesOfdoesn’t have amoduleparameter. This leads to warnings during the storyshots test for each of the provided Bowser components:Any components generated with
ignite generate componentwill also trigger this warning.The
moduleparameter is necessary to enable hot-module-replacement to work right:storybookjs/storybook#2022 (comment)
I've added it to all our components' story files, as well as to the component template.